Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/improve integration clients #541

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Feat/improve integration clients #541

merged 6 commits into from
Jun 13, 2024

Conversation

gcharest
Copy link
Contributor

Summary | Résumé

  • Update Google client to resolve supported argument from the method attributes
  • Update AWS Identity Store functions to only pass supported params

@gcharest gcharest requested a review from a team June 13, 2024 18:05
@gcharest gcharest self-assigned this Jun 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

GitHub Action status on ba64038 generated by comment-failure-action

Lint, format and test code

job url
null https://github.com/cds-snc/sre-bot/actions/runs/9504587450/job/26197565315

Build containers CI

No jobs failed 👍

@gcharest gcharest merged commit ad420fb into main Jun 13, 2024
7 checks passed
@gcharest gcharest deleted the feat/improve_integration_clients branch June 13, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylviamclaughlin sylviamclaughlin sylviamclaughlin approved these changes

Assignees

@gcharest gcharest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcharest @sylviamclaughlin