Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/toggle users vs groups syncs #496

Merged
merged 13 commits into from
May 8, 2024
Merged

Conversation

gcharest
Copy link
Contributor

@gcharest gcharest commented May 8, 2024

Summary | Résumé

  • Add support for deletion on either users and groups only: previous enable_delete would apply to both at the same time which was too restrictive
  • Fix the AWS groups memberships integration: response of delete resources is supposed to be an empty object but it also contains the response's metadata so condition was failing.

@gcharest gcharest requested a review from a team May 8, 2024 13:06
@gcharest gcharest self-assigned this May 8, 2024
@gcharest gcharest merged commit 92e1bad into main May 8, 2024
7 checks passed
@gcharest gcharest deleted the feat/toggle_users_vs_groups_syncs branch May 8, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants