Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/handle filters in list groups members #488

Merged
merged 6 commits into from
Apr 30, 2024
Merged

Feat/handle filters in list groups members #488

merged 6 commits into from
Apr 30, 2024

Conversation

gcharest
Copy link
Contributor

Summary | Résumé

  • Simplify docs on filters functions
  • Fix unit tests to use proper values
  • Update conftest fixtures to generate expected data format
  • Fix aws paginator to receive keys properly
  • Add support to AWS and Google list groups with members for improved performance when required:
    • instead of getting all groups from the integration and then call list memberships on each of them, only perform the operation on the subset needed.

@gcharest gcharest requested a review from a team April 30, 2024 15:45
@gcharest gcharest self-assigned this Apr 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited
Loading

GitHub Action status on 956cd72 generated by comment-failure-action

Lint, format and test code

job url
null https://github.com/cds-snc/sre-bot/actions/runs/8897743087/job/24433324820

Build containers CI

No jobs failed 👍

sylviamclaughlin
sylviamclaughlin approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@sylviamclaughlin sylviamclaughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all those improvements!

@gcharest gcharest merged commit 94b991c into main Apr 30, 2024
7 checks passed
@gcharest gcharest deleted the feat/handle_filters_in_list_groups_members branch April 30, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylviamclaughlin sylviamclaughlin sylviamclaughlin approved these changes

Assignees

@gcharest gcharest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcharest @sylviamclaughlin