Feat/provisioning module #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GitHub Action status on 692d6c1 generated by comment-failure-action Source code security scan using Bandit
Lint, format and test codeNo jobs failed 👍 Build containers CINo jobs failed 👍 |
| members_details = kwargs.get("members_details", True) | ||
|
|
||
| groups = [] | ||
| match integration_source: |
There was a problem hiding this comment.
So much better than several if statements!
app/modules/provisioning/groups.py
Outdated
| return groups | ||
|
|
||
|
|
||
| # def get_matching_groups(source_groups, target_groups, matching_key): |
There was a problem hiding this comment.
I assume you want to keep the commented code here?
| assert not mock_google_list_groups_with_members.called | ||
|
|
||
|
|
||
| # @patch("modules.provisioning.groups.filter_tools.get_nested_value") |
There was a problem hiding this comment.
Do you need this commented code here?
|
GitHub Action status on b43c133 generated by comment-failure-action Lint, format and test code
Build containers CINo jobs failed 👍 |
sylviamclaughlin
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé