Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/aws integration for client & identity store #482

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

gcharest
Copy link
Contributor

@gcharest gcharest commented Apr 25, 2024

Summary | Résumé

  • Add functions to handle conversion of snake case to pascal case
  • Fix client to convert kwargs with pascal case (instead of camel case like Google client)
  • Add functions to handle groups, groups memberships, users and grouping of the 3 objects together
  • Add global fixtures to handle Google and AWS API in tests

@gcharest gcharest requested a review from a team April 25, 2024 22:26
@gcharest gcharest self-assigned this Apr 25, 2024
Copy link

github-actions bot commented Apr 25, 2024

GitHub Action status on 3c36a92 generated by comment-failure-action

Lint, format and test code

job url
null https://github.com/cds-snc/sre-bot/actions/runs/8840199134/job/24275057804

Build containers CI

No jobs failed 👍

@gcharest gcharest enabled auto-merge (squash) April 25, 2024 22:32
# Google Discovery Directory Resource
# Base fixtures
@pytest.fixture
def google_groups():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixtures are great!

@gcharest gcharest merged commit 0e1cbd0 into main Apr 25, 2024
7 checks passed
@gcharest gcharest deleted the fix/aws_id_store_integration branch April 25, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants