Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/aws identity center integration #466

Merged
merged 17 commits into from
Apr 19, 2024
Merged

Feat/aws identity center integration #466

merged 17 commits into from
Apr 19, 2024

Conversation

gcharest
Copy link
Contributor

@gcharest gcharest commented Apr 18, 2024 •
edited
Loading

Summary | Résumé

  • Setup AWS integration with identity center

    • setup a reusable execute api call function
    • handle errors, including expected AWS errors (like resource not found)
    • Identity center functions:
      • Create, delete a user
      • Get a user_id
      • List all users
      • List all groups
      • List all users in a group

  • Move reusable api functions into dedicated integrations utils module

@gcharest gcharest requested a review from a team April 18, 2024 20:04
@gcharest gcharest self-assigned this Apr 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2024 •
edited
Loading

GitHub Action status on a4434fb generated by comment-failure-action

Lint, format and test code

job url
null https://github.com/cds-snc/sre-bot/actions/runs/8743990268/job/23995864466

Build containers CI

No jobs failed 👍

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

GitHub Action status on 1955fa5 generated by comment-failure-action

Lint, format and test code

job url
null https://github.com/cds-snc/sre-bot/actions/runs/8746424622/job/24003252924

Build containers CI

No jobs failed 👍

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

GitHub Action status on 358a179 generated by comment-failure-action

Lint, format and test code

job url
null https://github.com/cds-snc/sre-bot/actions/runs/8748014161/job/24007364026

Build containers CI

No jobs failed 👍

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

GitHub Action status on 361555c generated by comment-failure-action

Lint, format and test code

job url
null https://github.com/cds-snc/sre-bot/actions/runs/8756080421/job/24031684557

Build containers CI

No jobs failed 👍

@gcharest gcharest marked this pull request as ready for review April 19, 2024 17:33
sylviamclaughlin
sylviamclaughlin reviewed Apr 19, 2024
View reviewed changes
app/modules/dev/aws_dev.py
load_dotenv()


def aws_dev_command(client, body, respond):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to do anything? It just returns the user id.

patheard
patheard reviewed Apr 19, 2024
View reviewed changes
app/integrations/aws/client.py
return wrapper


@handle_aws_api_errors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like this approach to error handling

patheard
patheard approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@patheard patheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gcharest gcharest merged commit b75f0c7 into main Apr 19, 2024
7 checks passed
@gcharest gcharest deleted the feat/aws_identity_center_integration branch April 19, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylviamclaughlin sylviamclaughlin sylviamclaughlin left review comments

@patheard patheard patheard approved these changes

Assignees

@gcharest gcharest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gcharest @patheard @sylviamclaughlin