Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable a webhook #437

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Disable a webhook #437

merged 1 commit into from
Mar 27, 2024

Conversation

sylviamclaughlin
Copy link
Contributor

@sylviamclaughlin sylviamclaughlin commented Mar 26, 2024 •
edited
Loading

Summary | Résumé

The following changes were made:

  1. Properly disabled a webhook.
  2. The message that now appears shows properly when disabling a webhook (ie it says Webhook disabled by user) and when enabled now says Webhook enabled by user. It was reverse prevously.
  3. If a webhook is disabled, you will not be able to use it to send messages.
  4. Unit tests were added and changed.

Part of this PR closes #436

@sylviamclaughlin sylviamclaughlin requested a review from a team March 26, 2024 22:12
@sylviamclaughlin sylviamclaughlin self-assigned this Mar 26, 2024
@sylviamclaughlin sylviamclaughlin merged commit e6a1745 into main Mar 27, 2024
7 checks passed
@sylviamclaughlin sylviamclaughlin deleted the fix/fix_disabled_webhooks branch March 27, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patheard patheard patheard approved these changes

@gcharest gcharest gcharest approved these changes

Assignees

@sylviamclaughlin sylviamclaughlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix message when disabling a webhook
3 participants
@sylviamclaughlin @gcharest @patheard