-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/google workspace service #388
Conversation
GitHub Action status on cfb7fec generated by comment-failure-action Lint, format and test code
Build containers CINo jobs failed 👍 |
"cwd": "${workspaceFolder}/app" | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to commit the debugger configuration file? It might be intended, so I just want to make sure in case it was not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be made available so that we can use it in the Codespaces without fiddling around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Thank you for answering!
) | ||
.execute() | ||
) | ||
return results.get("files", []) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it that you will add all the other functions to do with the google drive such as writing to an excel file or a google document, later on right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that will need to be porte over once the service is properly configured
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this is for testing purposes so maybe I should make it available only when the dev- prefix is used
@@ -47,6 +47,8 @@ def sre_command(ack, command, logger, respond, client, body): | |||
webhook_helper.handle_webhook_command(args, client, body, respond) | |||
case "version": | |||
respond(f"SRE Bot version: {os.environ.get('GIT_SHA', 'unknown')}") | |||
case "google-service": | |||
google_service.google_service_command(client, body) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so that I understand this, the google_service_command lists the available folders correct (ie runs list-folders)? I assume that this is just for testing and will be removed at a later point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's also for development purposes so we could make it available only when the dev- prefix is called
@@ -26,6 +26,10 @@ def main(bot): | |||
APP_TOKEN = os.environ.get("APP_TOKEN") | |||
PREFIX = os.environ.get("PREFIX", "") | |||
|
|||
# Register Google Service command | |||
bot.command(f"/{PREFIX}google-service")(google_service.google_service_command) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I assume this is in place just for testing, correcting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly!
Summary | Résumé