feat: add the /secret command for encrypted-message #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GitHub Action status on 5438cf0 generated by comment-failure-action Source code security scan using Bandit
Lint, format and test code
Build containers CINo jobs failed 👍 |
|
GitHub Action status on ffc67d7 generated by comment-failure-action Source code security scan using Bandit
Lint, format and test codeNo jobs failed 👍 Build containers CINo jobs failed 👍 |
sylviamclaughlin
approved these changes
Jan 26, 2024
| ttl = view["state"]["values"]["product"]["secret_ttl"]["selected_option"]["value"] | ||
|
|
||
| # Encrypted message API | ||
| endpoint = "https://encrypted-message.cdssandbox.xyz/encrypt" |
There was a problem hiding this comment.
Super, super minor thing which we don't need to change, but the URL https://encrypted-message.cdssandbox.xyz might be better to live in a variable or secret since you are anyways using it in multiple places throughout your code. Again super minor.
There was a problem hiding this comment.
Agreed - I hardcoded it for now but should be made into an env in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
/secretcommand to generate one time encrypted message linksUse command
Select options
Get link to share:
