feat: add security group to the incident channel #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the `/incident` command so the `Security` user group is added to the incident channel when created.
Dive image results for
|
| Image | sre-bot:latest |
| Total Size | 1.64GiB |
| Inefficient Bytes | 90.20MiB |
| Efficiency Percentage | 96.29% |
| Total Layers | 21 |
See the PR run for more details
Dive image results for
|
| Image | sre-bot:latest |
| Total Size | 1.64GiB |
| Inefficient Bytes | 90.20MiB |
| Efficiency Percentage | 96.29% |
| Total Layers | 21 |
See the PR run for more details
sylviamclaughlin
approved these changes
Dec 6, 2023
Dive image results for
|
| Image | sre-bot:latest |
| Total Size | 1.64GiB |
| Inefficient Bytes | 90.20MiB |
| Efficiency Percentage | 96.29% |
| Total Layers | 21 |
See the PR run for more details
Dive image results for
|
| Image | sre-bot:latest |
| Total Size | 1.64GiB |
| Inefficient Bytes | 90.20MiB |
| Efficiency Percentage | 96.29% |
| Total Layers | 21 |
See the PR run for more details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the
/incidentcommand so the@securitySlack user group is added to the incident channel when created.This also adds the missing cybersecurity incident examples to the welcome messages.
Unfortunately adding the group ID directly does not work with the
conversations.inviteAPI method. This is why the user group members need to be looked up and then added individually.Related