add setuptools to waffles requirements.txt #338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Python 3.12 doesn't include distutils anymore so we need to get it from somewhere else. Setuptools is recommended.
Tested the action in the admin 3.12 branch. failed with waffles 53.0.0 but works with waffles from this branch.
Related Issues | Cartes liées
Test instructions | Instructions pour tester la modification
Look at https://github.com/cds-snc/notification-admin/actions/runs/12128468332/job/33814890096?pr=1996
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur