Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setuptools to waffles requirements.txt #338

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Dec 2, 2024

Summary | Résumé

Python 3.12 doesn't include distutils anymore so we need to get it from somewhere else. Setuptools is recommended.

Tested the action in the admin 3.12 branch. failed with waffles 53.0.0 but works with waffles from this branch.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

Look at https://github.com/cds-snc/notification-admin/actions/runs/12128468332/job/33814890096?pr=1996

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@sastels sastels marked this pull request as ready for review December 2, 2024 21:51
@sastels sastels requested a review from jzbahrai December 2, 2024 21:51
@sastels sastels merged commit 8ee66e4 into main Dec 2, 2024
4 checks passed
@sastels sastels deleted the waffles-setuptools branch December 2, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants