Skip to content

Commit

Permalink
Fix linter issues
Browse files Browse the repository at this point in the history
- Update make format task to check for all selected linter categories
  • Loading branch information
whabanks committed Sep 10, 2024
1 parent 5554421 commit 03cf34e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ clean-docker-containers: ## Clean up any remaining docker containers
format:
ruff check --select I --fix .
ruff format .
ruff check
poetry run mypy .
poetry sort

Expand Down
8 changes: 4 additions & 4 deletions tests/test_logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ class App:
handlers = logging.get_handlers(app)

assert len(handlers) == 1
assert type(handlers[0]) == builtin_logging.StreamHandler
assert type(handlers[0].formatter) == logging.CustomLogFormatter
assert type(handlers[0]) is builtin_logging.StreamHandler
assert type(handlers[0].formatter) is logging.CustomLogFormatter
assert not (tmpdir / "foo").exists()


Expand All @@ -85,8 +85,8 @@ class App:
handlers = logging.get_handlers(app)

assert len(handlers) == 1
assert type(handlers[0]) == builtin_logging.StreamHandler
assert type(handlers[0].formatter) == logging.JSONFormatter
assert type(handlers[0]) is builtin_logging.StreamHandler
assert type(handlers[0].formatter) is logging.JSONFormatter

# assert type(handlers[1]) == builtin_logging_handlers.WatchedFileHandler
# assert type(handlers[1].formatter) == logging.JSONFormatter
Expand Down

0 comments on commit 03cf34e

Please sign in to comment.