Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Removed broken quicksight dataset in aws and tfstate. Plan works locally" #996

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Revert "Removed broken quicksight dataset in aws and tfstate. Plan works locally" #996

merged 1 commit into from
Oct 31, 2023

Conversation

ben851
Copy link
Contributor

@ben851 ben851 commented Oct 31, 2023

Reverts #995

The plan works but apply still fails

@ben851 ben851 requested a review from sastels October 31, 2023 14:27
@ben851 ben851 requested a review from jimleroyer as a code owner October 31, 2023 14:27
sastels
sastels approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@ben851 ben851 merged commit 4635b68 into main Oct 31, 2023
3 checks passed
@ben851 ben851 deleted the revert-995-quicksight-provider-fix branch October 31, 2023 14:30
@sastels sastels mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sastels sastels sastels approved these changes

@jimleroyer jimleroyer Awaiting requested review from jimleroyer jimleroyer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben851 @sastels