Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alarms for new queues to email dashboard #988

Merged
merged 8 commits into from
Nov 7, 2023

Conversation

sastels
Copy link
Contributor

@sastels sastels commented Oct 25, 2023

Summary | Résumé

Alarms for send-email-* queues have been added, this adds them to the email dashboard.

@sastels sastels marked this pull request as ready for review October 26, 2023 15:03
@sastels sastels requested a review from jimleroyer as a code owner October 26, 2023 15:03
@sastels sastels requested a review from ben851 October 26, 2023 15:04
Copy link

github-actions bot commented Nov 7, 2023

Staging: common

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy
Show summary
CHANGE NAME
update aws_cloudwatch_dashboard.emails[0]
Show plan
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_cloudwatch_dashboard.emails[0] will be updated in-place
  ~ resource "aws_cloudwatch_dashboard" "emails" {
      ~ dashboard_body = jsonencode(
          ~ {
              ~ widgets = [
                    {
                        height     = 6
                        properties = {
                            liveData = true
                            metrics  = [
                                [
                                    "AWS/SES",
                                    "Send",
                                ],
                            ]
                            period   = 300
                            region   = "ca-central-1"
                            stacked  = true
                            stat     = "Sum"
                            title    = "Sent emails per 5mn"
                            view     = "timeSeries"
                        }
                        type       = "metric"
                        width      = 9
                        x          = 0
                        y          = 4
                    },
                  ~ {
                      ~ properties = {
                          ~ alarms = [
                              + "arn:aws:cloudwatch:ca-central-1:239043911459:alarm:sqs-send-email-high-queue-delay-warning",
                              + "arn:aws:cloudwatch:ca-central-1:239043911459:alarm:sqs-send-email-high-queue-delay-critical",
                              + "arn:aws:cloudwatch:ca-central-1:239043911459:alarm:sqs-send-email-medium-queue-delay-warning",
                              + "arn:aws:cloudwatch:ca-central-1:239043911459:alarm:sqs-send-email-medium-queue-delay-critical",
                              + "arn:aws:cloudwatch:ca-central-1:239043911459:alarm:sqs-send-email-low-queue-delay-warning",
                              + "arn:aws:cloudwatch:ca-central-1:239043911459:alarm:sqs-send-email-low-queue-delay-critical",
                                "arn:aws:cloudwatch:ca-central-1:239043911459:alarm:ses-bounce-rate-critical",
                                # (6 unchanged elements hidden)
                            ]
                            # (1 unchanged element hidden)
                        }
                        # (5 unchanged elements hidden)
                    },
                    {
                        height     = 6
                        properties = {
                            metrics = [
                                [
                                    "AWS/SES",
                                    "Bounce",
                                    {
                                        color = "#ff7f0e"
                                    },
                                ],
                            ]
                            period  = 900
                            region  = "ca-central-1"
                            stacked = true
                            stat    = "Sum"
                            title   = "Bounces per 15mn"
                            view    = "timeSeries"
                        }
                        type       = "metric"
                        width      = 9
                        x          = 9
                        y          = 4
                    },
                    # (18 unchanged elements hidden)
                ]
            }
        )
        id             = "Emails"
        # (2 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Warning: Argument is deprecated

  with aws_s3_bucket.csv_bucket,
  on s3.tf line 5, in resource "aws_s3_bucket" "csv_bucket":
   5: resource "aws_s3_bucket" "csv_bucket" {

Use the aws_s3_bucket_lifecycle_configuration resource instead

(and 51 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Releasing state lock. This may take a few moments...
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.primary"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_event_rule.aws_health[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.route53_resolver_query_log[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_failures[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_failures_us_west_2[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_us_west_2[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-bulk-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-bulk-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-inflights-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-inflights-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.contact-3-500-error-15-minutes-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.document-download-bucket-size-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.expired-inflight-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.expired-inflight-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.healtheck-page-slow-response-critical[0]"]
WARN -...

@sastels sastels merged commit 73b4e12 into main Nov 7, 2023
3 checks passed
@sastels sastels deleted the new-email-alarms-in-dashboard branch November 7, 2023 19:02
@jzbahrai jzbahrai mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants