Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert EKS private access only #206

Merged
merged 1 commit into from
Feb 24, 2021
Merged

fix: revert EKS private access only #206

merged 1 commit into from
Feb 24, 2021

Conversation

AntoineAugusti
Copy link
Contributor

Reverts changes introduced in #201 and #204. Logged an issue to tackle this later #205

@AntoineAugusti AntoineAugusti marked this pull request as ready for review February 24, 2021 21:20
jimleroyer
jimleroyer approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@jimleroyer jimleroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a proper revert to me. 👍

@AntoineAugusti AntoineAugusti merged commit a6c08a9 into main Feb 24, 2021
@AntoineAugusti AntoineAugusti deleted the revert-eks-private-access branch February 24, 2021 21:23
@AntoineAugusti AntoineAugusti mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimleroyer jimleroyer jimleroyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntoineAugusti @jimleroyer