Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch off notification-terraform-api #1735

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Switch off notification-terraform-api #1735

merged 1 commit into from
Jan 27, 2025

Conversation

ben851
Copy link
Contributor

@ben851 ben851 commented Jan 27, 2025

Summary | Résumé

Create dev is failing when trying to use the notification-api-terraform role for AWS. Not sure why but also not sure why we're not just using the regular terraform role. Lets try this.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

Merge to main, run create-dev

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@ben851 ben851 requested a review from a team January 27, 2025 13:55
@ben851 ben851 requested a review from jimleroyer as a code owner January 27, 2025 13:55
Copy link
Contributor

@P0NDER0SA P0NDER0SA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeps

@ben851 ben851 merged commit a64de23 into main Jan 27, 2025
3 checks passed
@ben851 ben851 deleted the dev-tf-acct branch January 27, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants