Add a budget alert for when we use a lot of cloudwatch data scanning #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[review]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aws/common/budget.tf
Outdated
| @@ -23,6 +23,38 @@ resource "aws_budgets_budget" "notify_global" { | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_budgets_budget" "cloudwatch_data_scanned" { | |||
| name = "coudwatch-data-scanned-budget" | |||
There was a problem hiding this comment.
There is a typo in the budget name. It should be cloudwatch-data-scanned-budget instead of coudwatch-data-scanned-budget.
staging: common✅ Terraform Init: Plan: 5 to add, 0 to change, 4 to destroyShow summary
Show planResource actions are indicated with the following symbols:
+ create
-/+ destroy and then create replacement
Terraform will perform the following actions:
# aws_budgets_budget.cloudwatch_data_scanned will be created
+ resource "aws_budgets_budget" "cloudwatch_data_scanned" {
+ account_id = (known after apply)
+ arn = (known after apply)
+ budget_type = "USAGE"
+ id = (known after apply)
+ limit_amount = "10000"
+ limit_unit = "GB"
+ name = "cloudwatch-data-scanned-budget"
+ name_prefix = (known after apply)
+ tags_all = (known after apply)
+ time_period_end = "2087-06-15_00:00"
+ time_period_start = (known after apply)
+ time_unit = "DAILY"
+ cost_filter {
+ name = "UsageType"
+ values = [
+ "CAN1-DataScanned-Bytes",
]
}
+ cost_types (known after apply)
+ notification {
+ comparison_operator = "GREATER_THAN"
+ notification_type = "ACTUAL"
+ subscriber_email_addresses = []
+ subscriber_sns_topic_arns = [
+ "arn:aws:sns:ca-central-1:239043911459:alert-general",
]
+ threshold = 100
+ threshold_type = "PERCENTAGE"
}
+ notification {
+ comparison_operator = "GREATER_THAN"
+ notification_type = "ACTUAL"
+ subscriber_email_addresses = []
+ subscriber_sns_topic_arns = [
+ "arn:aws:sns:ca-central-1:239043911459:alert-general",
]
+ threshold = 80
+ threshold_type = "PERCENTAGE"
}
}
# module.notify_slack_critical.module.lambda.null_resource.archive[0] must be replaced
-/+ resource "null_resource" "archive" {
~ id = "434405101312382330" -> (known after apply)
~ triggers = { # forces replacement
~ "timestamp" = "1734450609736004200" -> "1734634570101046000"
# (1 unchanged element hidden)
}
}
# module.notify_slack_general.module.lambda.null_resource.archive[0] must be replaced
-/+ resource "null_resource" "archive" {
~ id = "5658221801416866527" -> (known after apply)
~ triggers = { # forces replacement
~ "timestamp" = "1734450602570921000" -> "1734634563989798000"
# (1 unchanged element hidden)
}
}
# module.notify_slack_ok.module.lambda.null_resource.archive[0] must be replaced
-/+ resource "null_resource" "archive" {
~ id = "4965436936612757236" -> (known after apply)
~ triggers = { # forces replacement
~ "timestamp" = "1734450609738267800" -> "1734634570133648000"
# (1 unchanged element hidden)
}
}
# module.notify_slack_warning.module.lambda.null_resource.archive[0] must be replaced
-/+ resource "null_resource" "archive" {
~ id = "780507589162386774" -> (known after apply)
~ triggers = { # forces replacement
~ "timestamp" = "1734450609783591000" -> "1734634570092058000"
# (1 unchanged element hidden)
}
}
Plan: 5 to add, 0 to change, 4 to destroy.
Warning: Argument is deprecated
with aws_s3_bucket.csv_bucket,
on s3.tf line 5, in resource "aws_s3_bucket" "csv_bucket":
5: resource "aws_s3_bucket" "csv_bucket" {
Use the aws_s3_bucket_server_side_encryption_configuration resource instead
(and 65 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Saved the plan to: plan.tfplan
To perform exactly these actions, run the following command to apply:
terraform apply "plan.tfplan"
Show Conftest resultsWARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.ad_hoc"]
WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.build_tables"]
WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.primary"]
WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.support"]
WARN - plan.json - main - Missing Common Tags: ["aws_budgets_budget.cloudwatch_data_scanned"]
WARN - plan.json - main - Missing Common Tags: ["aws_budgets_budget.notify_global"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_event_rule.aws_health[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.route53_resolver_query_log[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_failures[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_failures_us_west_2[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_us_west_2[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-bulk-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-bulk-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-inflights-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-inflights-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.contact-3-500-error-15-minutes-critical[0]"]
WARN - plan.json - main - Missing Common... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
We had a large charge in AWS Cloudwatch for querying data. This budget will alert us when we're going crazy in the future.
Related Issues | Cartes liées
Chore
Before merging this PR
Read code suggestions left by the
cds-ai-codereviewer bot. Address
valid suggestions and shortly write down reasons to not address others. To help
with the classification of the comments, please use these reactions on each of the
comments made by the AI review:
The classifications will be extracted and summarized into an analysis of how helpful
or not the AI code review really is.
Test instructions | Instructions pour tester la modification
TF Apply
Verify budget shows data in target environment
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur