Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak sms keywords AIDE and INFO #1694

Merged
merged 3 commits into from
Dec 10, 2024
Merged

tweak sms keywords AIDE and INFO #1694

merged 3 commits into from
Dec 10, 2024

Conversation

sastels
Copy link
Contributor

@sastels sastels commented Dec 9, 2024

Summary | Résumé

Correction suggested by @jprince-cds

For the AIDE keyword, since this is French, we should probably use Notification GC instead of GC Notify. For the INFO keyword, since this is a bilingual guidance, we should probably add Notification GC in addition to GC Notify that is already mentioned.

Test instructions | Instructions pour tester la modification

Script has been run against staging, you can see the resonse to AIDE or INFO there.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@sastels sastels marked this pull request as ready for review December 9, 2024 15:44
@sastels sastels requested a review from jimleroyer as a code owner December 9, 2024 15:44
@sastels sastels requested review from jzbahrai, jprince-cds and a team December 9, 2024 15:44
Copy link
Contributor

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@@ -76,7 +76,7 @@
},
{
"Keyword": "INFO",
"KeywordMessage": "GC Notify: More info at https://notification.canada.ca Data rates apply. Plus d’informations à https://notification.canada.ca Frais de msg/donnée std applicables.",
"KeywordMessage": "GC Notify: More info at https://notification.canada.ca Data rates apply. Notification GC: Plus d’informations à https://notification.canada.ca Frais de msg/donnée std applicables.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

données would need an s like in the other responses.

@sastels sastels merged commit 5cb9d38 into main Dec 10, 2024
3 checks passed
@sastels sastels deleted the tweak-aide-info-keywords branch December 10, 2024 19:21
@ben851 ben851 mentioned this pull request Dec 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants