k8s upgrade for prod

[ben851]

Summary | Résumé

Upgrading prod to latest K8s node version
1.31.2-20241121

Related Issues | Cartes liées

Chore

Test instructions | Instructions pour tester la modification

Smoke test prod after release

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

• This PR does not break existing functionality.
• This PR does not violate GCNotify's privacy policies.
• This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
• This PR does not significantly alter performance.
• Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

[github-actions]

staging: common

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

⚠️   Warning: resources will be destroyed by this change!

Plan: 4 to add, 0 to change, 4 to destroy

Show summary

CHANGE	NAME
recreate	module.notify_slack_critical.module.lambda.null_resource.archive[0]
	module.notify_slack_general.module.lambda.null_resource.archive[0]
	module.notify_slack_ok.module.lambda.null_resource.archive[0]
	module.notify_slack_warning.module.lambda.null_resource.archive[0]

Show plan

Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.notify_slack_critical.module.lambda.null_resource.archive[0] must be replaced
-/+ resource "null_resource" "archive" {
      ~ id       = "8828478312453630231" -> (known after apply)
      ~ triggers = { # forces replacement
          ~ "timestamp" = "1733162479117352000" -> "1733233298642744000"
            # (1 unchanged element hidden)
        }
    }

  # module.notify_slack_general.module.lambda.null_resource.archive[0] must be replaced
-/+ resource "null_resource" "archive" {
      ~ id       = "2915651801487460723" -> (known after apply)
      ~ triggers = { # forces replacement
          ~ "timestamp" = "1733162471687652200" -> "1733233290182909000"
            # (1 unchanged element hidden)
        }
    }

  # module.notify_slack_ok.module.lambda.null_resource.archive[0] must be replaced
-/+ resource "null_resource" "archive" {
      ~ id       = "9189553111764606202" -> (known after apply)
      ~ triggers = { # forces replacement
          ~ "timestamp" = "1733162479050034000" -> "1733233298629123000"
            # (1 unchanged element hidden)
        }
    }

  # module.notify_slack_warning.module.lambda.null_resource.archive[0] must be replaced
-/+ resource "null_resource" "archive" {
      ~ id       = "6225414939552856390" -> (known after apply)
      ~ triggers = { # forces replacement
          ~ "timestamp" = "1733162479132375000" -> "1733233298652044000"
            # (1 unchanged element hidden)
        }
    }

Plan: 4 to add, 0 to change, 4 to destroy.

Warning: Argument is deprecated

  with aws_s3_bucket.csv_bucket,
  on s3.tf line 5, in resource "aws_s3_bucket" "csv_bucket":
   5: resource "aws_s3_bucket" "csv_bucket" {

Use the aws_s3_bucket_lifecycle_configuration resource instead

(and 65 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"

Show Conftest results

WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.ad_hoc"]
WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.build_tables"]
WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.primary"]
WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.support"]
WARN - plan.json - main - Missing Common Tags: ["aws_budgets_budget.notify_global"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_event_rule.aws_health[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.route53_resolver_query_log[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_failures[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_failures_us_west_2[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_us_west_2[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-bulk-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-bulk-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-inflights-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-inflights-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.contact-3-500-error-15-minutes-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.document-download-bucket-size-warning[0]"]
WARN - plan.json...

[github-actions]

staging: newrelic

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy

Show summary

CHANGE	NAME
update	newrelic_cloud_aws_integrations.newrelic_cloud_integration_pull[0]

Show plan

Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # newrelic_cloud_aws_integrations.newrelic_cloud_integration_pull[0] will be updated in-place
  ~ resource "newrelic_cloud_aws_integrations" "newrelic_cloud_integration_pull" {
        id                = "225924"
        # (2 unchanged attributes hidden)

      ~ lambda {
          - fetch_tags               = true -> null
          - metrics_polling_interval = 300 -> null
            # (3 unchanged attributes hidden)
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"

Show Conftest results

WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_stream.newrelic_metric_stream[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.newrelic_aws_permissions[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.firehose_newrelic_role[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.metric_stream_to_firehose[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.newrelic_aws_role[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.newrelic_configuration_recorder[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_kinesis_firehose_delivery_stream.newrelic_firehose_stream[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_s3_bucket.newrelic_aws_bucket[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_s3_bucket.newrelic_configuration_recorder_s3[0]"]

28 tests, 19 passed, 9 warnings, 0 failures, 0 exceptions

[P0NDER0SA]

Yes!