Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new keywords to set_sms_keywords.py #1686

Merged
merged 6 commits into from
Dec 3, 2024
Merged

add new keywords to set_sms_keywords.py #1686

merged 6 commits into from
Dec 3, 2024

Conversation

sastels
Copy link
Contributor

@sastels sastels commented Dec 2, 2024

Summary | Résumé

Add new SMS keywords and responses.

Related Issues | Cartes liées

Before merging this PR

Read code suggestions left by the
cds-ai-codereviewer bot. Address
valid suggestions and shortly write down reasons to not address others. To help
with the classification of the comments, please use these reactions on each of the
comments made by the AI review:

Classification Reaction Emoticon
Useful +1 👍
Noisy eyes 👀
Hallucination confused 😕
Wrong but teachable rocket 🚀
Wrong and incorrect -1 👎

The classifications will be extracted and summarized into an analysis of how helpful
or not the AI code review really is.

Test instructions | Instructions pour tester la modification

already ran on staging, you can send yourself a text and reply to it.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@sastels sastels marked this pull request as ready for review December 3, 2024 15:22
@sastels sastels requested a review from jimleroyer as a code owner December 3, 2024 15:22
Copy link

@YedidaZalik YedidaZalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great --I tested all the word variations and all work - merci beaucoup!

@YedidaZalik
Copy link

Proofread opt in/opt out messages in both EN and FR
Sent screenshots of FR messages to Marie-Sophie who confirmed correct

@sastels sastels requested a review from a team December 3, 2024 18:41
Copy link
Member

@andrewleith andrewleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, keywords all seem to be working!

Copy link
Contributor

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but Steve promised to create a card to run this script as a null resource with the rest of the pinpoint garbage :)

@sastels sastels merged commit 9714658 into main Dec 3, 2024
3 checks passed
@sastels sastels deleted the update-keywords branch December 3, 2024 18:58
@whabanks whabanks mentioned this pull request Dec 10, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants