Release 2.12.20

[whabanks]

Summary | Résumé

Release 2.12.20

• Making the github arc runner alarm more generic and scoped to runners #1371
• Remove dimensions from metric_filter #1373
• Add warning and critical alarms for callbacks #1352
• Remove Retry: string from pattern #1372
• Pinpoint dashboard #1369
• Enabling cert #1368

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

• This PR does not break existing functionality.
• This PR does not violate GCNotify's privacy policies.
• This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
• This PR does not significantly alter performance.
• Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

[github-actions]

Production: common

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 0 to change, 0 to destroy

Show summary

CHANGE	NAME

Show plan

Changes to Outputs:
  + celery_queue_prefix                                 = "eks-notification-canada-ca"
  + sqs_send_sms_high_queue_delay_critical_arn          = "arn:aws:cloudwatch:ca-central-1:296255494825:alarm:sqs-send-sms-high-queue-delay-critical"
  + sqs_send_sms_high_queue_delay_warning_arn           = "arn:aws:cloudwatch:ca-central-1:296255494825:alarm:sqs-send-sms-high-queue-delay-warning"
  + sqs_send_sms_low_queue_delay_critical_arn           = "arn:aws:cloudwatch:ca-central-1:296255494825:alarm:sqs-send-sms-low-queue-delay-critical"
  + sqs_send_sms_low_queue_delay_warning_arn            = "arn:aws:cloudwatch:ca-central-1:296255494825:alarm:sqs-send-sms-low-queue-delay-warning"
  + sqs_send_sms_medium_queue_delay_critical_arn        = "arn:aws:cloudwatch:ca-central-1:296255494825:alarm:sqs-send-sms-medium-queue-delay-critical"
  + sqs_send_sms_medium_queue_delay_warning_arn         = "arn:aws:cloudwatch:ca-central-1:296255494825:alarm:sqs-send-sms-medium-queue-delay-warning"

You can apply this plan to save these new output values to the Terraform
state, without changing any real infrastructure.

Warning: Argument is deprecated

  with aws_s3_bucket.csv_bucket,
  on s3.tf line 5, in resource "aws_s3_bucket" "csv_bucket":
   5: resource "aws_s3_bucket" "csv_bucket" {

Use the aws_s3_bucket_lifecycle_configuration resource instead

(and 71 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"

Show Conftest results

WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.ad_hoc"]
WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.build_tables"]
WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.primary"]
WARN - plan.json - main - Missing Common Tags: ["aws_athena_workgroup.support"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_event_rule.aws_health[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.route53_resolver_query_log[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_failures[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_failures_us_west_2[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.sns_deliveries_us_west_2[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-bulk-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-bulk-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-inflights-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-inflights-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-not-being-processed-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.bulk-not-being-processed-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.contact-3-500-error-15-minutes-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.document-download-bucket-size-warning[0]"]
WARN - plan.json - main - Missing Common Tags:...

[github-actions]

Production: pinpoint_to_sqs_sms_callbacks

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
❌   Terraform Plan: failed
❌   Conftest: failed

Show plan

Error: No value for required variable

  on variables.tf line 55:
  55: variable "celery_queue_prefix" {

The root module input variable "celery_queue_prefix" is not set, and has no
default value. Use a -var or -var-file command line argument to provide a
value for this variable.

Error: No value for required variable

  on variables.tf line 60:
  60: variable "sqs_send_sms_high_queue_delay_warning_arn" {

The root module input variable "sqs_send_sms_high_queue_delay_warning_arn" is
not set, and has no default value. Use a -var or -var-file command line
argument to provide a value for this variable.

Error: No value for required variable

  on variables.tf line 65:
  65: variable "sqs_send_sms_high_queue_delay_critical_arn" {

The root module input variable "sqs_send_sms_high_queue_delay_critical_arn"
is not set, and has no default value. Use a -var or -var-file command line
argument to provide a value for this variable.

Error: No value for required variable

  on variables.tf line 70:
  70: variable "sqs_send_sms_medium_queue_delay_warning_arn" {

The root module input variable "sqs_send_sms_medium_queue_delay_warning_arn"
is not set, and has no default value. Use a -var or -var-file command line
argument to provide a value for this variable.

Error: No value for required variable

  on variables.tf line 75:
  75: variable "sqs_send_sms_medium_queue_delay_critical_arn" {

The root module input variable "sqs_send_sms_medium_queue_delay_critical_arn"
is not set, and has no default value. Use a -var or -var-file command line
argument to provide a value for this variable.

Error: No value for required variable

  on variables.tf line 80:
  80: variable "sqs_send_sms_low_queue_delay_warning_arn" {

The root module input variable "sqs_send_sms_low_queue_delay_warning_arn" is
not set, and has no default value. Use a -var or -var-file command line
argument to provide a value for this variable.

Error: No value for required variable

  on variables.tf line 85:
  85: variable "sqs_send_sms_low_queue_delay_critical_arn" {

The root module input variable "sqs_send_sms_low_queue_delay_critical_arn" is
not set, and has no default value. Use a -var or -var-file command line
argument to provide a value for this variable.
time=2024-06-12T16:16:09Z level=error msg=Terraform invocation failed in /home/runner/work/notification-terraform/notification-terraform/env/production/pinpoint_to_sqs_sms_callbacks/.terragrunt-cache/_ZxVvgj5vgFVQ-ROYB0bEp9KVBo/otNjPEaGW-4SZcUM-28oiXiKtfo/aws/pinpoint_to_sqs_sms_callbacks prefix=[/home/runner/work/notification-terraform/notification-terraform/env/production/pinpoint_to_sqs_sms_callbacks] 
time=2024-06-12T16:16:09Z level=error msg=1 error occurred:
	* exit status 1

[whabanks]

Closing to release 2.12.21 instead.