Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pinpoint pool #1339

Merged
merged 2 commits into from
May 22, 2024
Merged

Rename pinpoint pool #1339

merged 2 commits into from
May 22, 2024

Conversation

sastels
Copy link
Contributor

@sastels sastels commented May 22, 2024

Summary | Résumé

We changed the language around pinpoint pools from "shortcode and longcode" to "shortcode and default" in this PR. Here we update the script that created these pools.

Note that I have manually changed the name of the pools in staging and production to default-pool, so this changed script should not change / create anything.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

none

Release Instructions | Instructions pour le déploiement

None

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@sastels sastels force-pushed the rename-default-pinpoint-pool branch from 347f4ec to d21a2e7 Compare May 22, 2024 18:06
@sastels sastels marked this pull request as ready for review May 22, 2024 18:39
@sastels sastels requested a review from jimleroyer as a code owner May 22, 2024 18:39
@sastels sastels requested a review from a team May 22, 2024 18:55
Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@sastels sastels merged commit 27c709c into main May 22, 2024
3 checks passed
@sastels sastels deleted the rename-default-pinpoint-pool branch May 22, 2024 19:50
@sastels sastels mentioned this pull request May 29, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants