fix release: 2.6.35

[sastels]

Summary | Résumé

• Fix / Increase cloudformation timeout #1235

increase the timeout on the QuickSight SMSUsage - Notifications dataset

Related Issues | Cartes liées

• https://app.zenhub.com/workspaces/notify-planning-core-6411dfb7c95fb80014e0cab0/issues/gh/cds-snc/notification-planning-core/309

Test instructions | Instructions pour tester la modification

See if the apply works.

Release Instructions | Instructions pour le déploiement

revert #1235 and then #1331 if this doesn't work.

Reviewer checklist | Liste de vérification du réviseur

• This PR does not break existing functionality.
• This PR does not violate GCNotify's privacy policies.
• This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
• This PR does not significantly alter performance.
• Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

[github-actions]

Production: quicksight

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

⚠️   Warning: resources will be destroyed by this change!

Plan: 2 to add, 0 to change, 1 to destroy

Show summary

CHANGE	NAME
add	aws_quicksight_refresh_schedule.sms-usage-notifications
recreate	aws_cloudformation_stack.sms-usage-notifications

Show plan

Resource actions are indicated with the following symbols:
  + create
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # aws_cloudformation_stack.sms-usage-notifications is tainted, so must be replaced
-/+ resource "aws_cloudformation_stack" "sms-usage-notifications" {
      - disable_rollback   = false -> null
      ~ id                 = "arn:aws:cloudformation:ca-central-1:296255494825:stack/sms-usage-notifications/07e25ce0-f1c9-11ee-9ebf-02e89565c19f" -> (known after apply)
        name               = "sms-usage-notifications"
      ~ outputs            = {} -> (known after apply)
      ~ parameters         = {} -> (known after apply)
      + policy_body        = (known after apply)
      - tags               = {} -> null
      ~ tags_all           = {} -> (known after apply)
      - timeout_in_minutes = 0 -> null
        # (2 unchanged attributes hidden)

      + timeouts {
          + create = "2h"
          + delete = "20m"
          + update = "2h"
        }
    }

  # aws_quicksight_refresh_schedule.sms-usage-notifications will be created
  + resource "aws_quicksight_refresh_schedule" "sms-usage-notifications" {
      + arn            = (known after apply)
      + aws_account_id = (known after apply)
      + data_set_id    = "sms-usage-notifications"
      + id             = (known after apply)
      + schedule_id    = "schedule-sms-usage-notifications"

      + schedule {
          + refresh_type          = "FULL_REFRESH"
          + start_after_date_time = (known after apply)

          + schedule_frequency {
              + interval        = "DAILY"
              + time_of_the_day = "07:45"
              + timezone        = (known after apply)
            }
        }
    }

Plan: 2 to add, 0 to change, 1 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"

Show Conftest results

WARN - plan.json - main - Missing Common Tags: ["aws_cloudformation_stack.sms-usage-notifications"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.quicksight-rds"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.quicksight-s3-usage"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.quicksight_vpc_connection_ec2"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.quicksight_vpc_connection_iam"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.quicksight"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.vpc_connection_role"]
WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.jobs"]
WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.login_events"]
WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.notifications"]
WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.organisation"]
WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.services"]
WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.sms_usage"]
WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.templates"]
WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_set.users"]
WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_source.rds"]
WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_data_source.s3_sms_usage"]
WARN - plan.json - main - Missing Common Tags: ["aws_quicksight_vpc_connection.rds"]
WARN - plan.json - main - Missing Common Tags: ["aws_s3_object.manifest_file"]

38 tests, 19 passed, 19 warnings, 0 failures, 0 exceptions

[jimleroyer]

LGTM