Skip to content

Commit

Permalink
delete bounce rate over 5% warning (#1006)
Browse files Browse the repository at this point in the history
Co-authored-by: Jumana B <[email protected]>
  • Loading branch information
sastels and jzbahrai authored Nov 7, 2023
1 parent 73b4e12 commit fe0e711
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 29 deletions.
17 changes: 1 addition & 16 deletions aws/eks/cloudwatch_alarms.tf
Original file line number Diff line number Diff line change
Expand Up @@ -409,21 +409,6 @@ resource "aws_cloudwatch_metric_alarm" "logs-1-bounce-rate-1-minute-critical" {
alarm_actions = [var.sns_alert_warning_arn]
}

resource "aws_cloudwatch_metric_alarm" "logs-1-bounce-rate-1-minute-warning" {
count = var.cloudwatch_enabled ? 1 : 0
alarm_name = "logs-1-warning-bounce-rate-3-minutes-warning"
alarm_description = "One service exceeding 5% bounce rate in 3 minutes"
comparison_operator = "GreaterThanOrEqualToThreshold"
evaluation_periods = "3"
metric_name = aws_cloudwatch_log_metric_filter.bounce-rate-warning[0].metric_transformation[0].name
namespace = aws_cloudwatch_log_metric_filter.bounce-rate-warning[0].metric_transformation[0].namespace
period = 60
statistic = "Sum"
threshold = 1
treat_missing_data = "notBreaching"
alarm_actions = [var.sns_alert_warning_arn]
}

resource "aws_cloudwatch_metric_alarm" "kubernetes-failed-nodes" {
count = var.cloudwatch_enabled ? 1 : 0
alarm_name = "kubernetes-failed-nodes"
Expand Down Expand Up @@ -729,4 +714,4 @@ resource "aws_cloudwatch_metric_alarm" "documentation-evicted-pods" {
alarm_actions = [var.sns_alert_warning_arn]
ok_actions = [var.sns_alert_warning_arn]
insufficient_data_actions = [var.sns_alert_warning_arn]
}
}
13 changes: 0 additions & 13 deletions aws/eks/cloudwatch_log.tf
Original file line number Diff line number Diff line change
Expand Up @@ -89,19 +89,6 @@ resource "aws_cloudwatch_log_metric_filter" "bounce-rate-critical" {
}
}

resource "aws_cloudwatch_log_metric_filter" "bounce-rate-warning" {
count = var.cloudwatch_enabled ? 1 : 0
name = "bounce-rate-warning"
pattern = "warning bounce rate threshold of 5"
log_group_name = aws_cloudwatch_log_group.notification-canada-ca-eks-application-logs[0].name

metric_transformation {
name = "bounce-rate-warning"
namespace = "LogMetrics"
value = "1"
}
}

resource "aws_cloudwatch_log_metric_filter" "api-evicted-pods" {
count = var.cloudwatch_enabled ? 1 : 0
name = "api-evicted-pods"
Expand Down

0 comments on commit fe0e711

Please sign in to comment.