Skip to content

Commit

Permalink
tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
sastels committed Jun 6, 2024
1 parent 55c7087 commit a9ba13e
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion aws/common/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -211,4 +211,4 @@ output "subnet_cidr_blocks" {

output "sns_monthly_spend_limit" {
value = var.sns_monthly_spend_limit
}
}
4 changes: 0 additions & 4 deletions aws/pinpoint_to_sqs_sms_callbacks/cloudwatch_alarms.tf
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ resource "aws_cloudwatch_metric_alarm" "lambda-image-pinpoint-delivery-receipts-
}
}


resource "aws_cloudwatch_metric_alarm" "pinpoint-spending-warning" {
count = var.cloudwatch_enabled ? 1 : 0
alarm_name = "pinpoint-spending-warning"
Expand Down Expand Up @@ -105,7 +104,6 @@ resource "aws_cloudwatch_metric_alarm" "pinpoint-spending-critical" {
ok_actions = [var.sns_alert_ok_arn]
}


resource "aws_cloudwatch_metric_alarm" "pinpoint-sms-success-rate-warning" {
count = var.cloudwatch_enabled ? 1 : 0
alarm_name = "pinpoint-sms-success-rate-warning"
Expand All @@ -117,7 +115,6 @@ resource "aws_cloudwatch_metric_alarm" "pinpoint-sms-success-rate-warning" {
alarm_actions = [var.sns_alert_warning_arn]
treat_missing_data = "notBreaching"


metric_query {
id = "success_rate"
expression = "successes / (successes + failures)"
Expand Down Expand Up @@ -190,7 +187,6 @@ resource "aws_cloudwatch_metric_alarm" "sns-sms-success-rate-canadian-numbers-cr
}
}


resource "aws_cloudwatch_metric_alarm" "pinpoint-sms-blocked-as-spam-warning" {
count = var.cloudwatch_enabled ? 1 : 0
alarm_name = "pinpoint-sms-blocked-as-spam-warning"
Expand Down
1 change: 0 additions & 1 deletion aws/pinpoint_to_sqs_sms_callbacks/cloudwatch_logs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ resource "aws_cloudwatch_log_metric_filter" "pinpoint-sms-successes" {
}
}


resource "aws_cloudwatch_log_metric_filter" "pinpoint-sms-failures" {
count = var.cloudwatch_enabled ? 1 : 0
name = "pinpoint-sms-failures"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,4 @@ inputs = {
pinpoint_to_sqs_sms_callbacks_ecr_repository_url = dependency.ecr.outputs.pinpoint_to_sqs_sms_callbacks_ecr_repository_url
pinpoint_to_sqs_sms_callbacks_ecr_arn = dependency.ecr.outputs.pinpoint_to_sqs_sms_callbacks_ecr_arn
pinpoint_monthly_spend_limit = dependency.common.outputs.sns_monthly_spend_limit

}
1 change: 0 additions & 1 deletion env/staging/pinpoint_to_sqs_sms_callbacks/terragrunt.hcl
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ inputs = {
pinpoint_to_sqs_sms_callbacks_ecr_repository_url = dependency.ecr.outputs.pinpoint_to_sqs_sms_callbacks_ecr_repository_url
pinpoint_to_sqs_sms_callbacks_ecr_arn = dependency.ecr.outputs.pinpoint_to_sqs_sms_callbacks_ecr_arn
pinpoint_monthly_spend_limit = dependency.common.outputs.sns_monthly_spend_limit

}

terraform {
Expand Down

0 comments on commit a9ba13e

Please sign in to comment.