Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch ghaction slack notif to curl #265

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

jimleroyer
Copy link
Member

Summary | Résumé

Reverting to our good old curl command to post to Slack.

Test instructions | Instructions pour tester la modification

Merge and test.

@jimleroyer jimleroyer requested review from sastels and ben851 December 14, 2023 21:18
@jimleroyer jimleroyer changed the title Fix/switch ghaction slack notif to curl Switch ghaction slack notif to curl Dec 14, 2023
Copy link

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion, LGTM 💪

SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
- name: Notify Slack channel if this job failed
run: |
json="{'text':'Core team tech debt show-off :muscle: :melting_face:\nBug: ${{ needs.count_bug_issues.outputs.count }}, Incident Actions: ${{ needs.count_incident_action_issues.outputs.count }}, Tech Debt issues: ${{ needs.count_tech_debt_issues.outputs.count }}'}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
json="{'text':'Core team tech debt show-off :muscle: :melting_face:\nBug: ${{ needs.count_bug_issues.outputs.count }}, Incident Actions: ${{ needs.count_incident_action_issues.outputs.count }}, Tech Debt issues: ${{ needs.count_tech_debt_issues.outputs.count }}'}"
json="{'text':'Core team tech debt show-off :muscle: :melting_face:\nBugs: ${{ needs.count_bug_issues.outputs.count }}, Incident Actions: ${{ needs.count_incident_action_issues.outputs.count }}, Tech Debt issues: ${{ needs.count_tech_debt_issues.outputs.count }}'}"

@jimleroyer jimleroyer merged commit 273b226 into main Dec 14, 2023
4 checks passed
@jimleroyer jimleroyer deleted the fix/switch-ghaction-slack-notif-to-curl branch December 14, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants