Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching test env vars credentials to prod not staging #3210

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ben851
Copy link
Collaborator

@ben851 ben851 commented Dec 17, 2024

What happens when your PR merges?

When we removed staging from the test env vars job, I accidentally removed the production login instead of the staging.

What are you changing?

  • Releasing a new version of Notify
  • Changing kubernetes configuration
  • Github workflows

Provide some background on the changes

Helm migration

If you are releasing a new version of Notify, what components are you updating

  • API
  • Admin
  • Documentation
  • Document download API

Checklist if releasing new version

Checklist if making changes to Kubernetes

  • I know how to get kubectl credentials in case it catches on fire

After merging this PR

  • I have verified that the tests / deployment actions succeeded
  • I have verified that any affected pods were restarted successfully
  • I have verified that I can still log into Notify production
  • I have verified that the smoke tests still pass on production
  • I have communicated the release in the #notify Slack channel.

@ben851 ben851 requested a review from a team December 17, 2024 18:47
@ben851 ben851 requested a review from jimleroyer as a code owner December 17, 2024 18:47
Copy link

xray-daemon	xray     	13      	2024-12-17 14:27:34.144207837 +0000 UTC	deployed	aws-xray-4.0.8	3.3.12     

ingress	nginx    	14      	2024-12-17 14:27:37.076383404 +0000 UTC	deployed	nginx-ingress-1.1.2	3.4.2      

Comparing release=notify-documentation, chart=charts/notify-documentation
Comparing release=notify-api, chart=charts/notify-api
Comparing release=notify-admin, chart=charts/notify-admin
Comparing release=notify-document-download, chart=charts/notify-document-download
Comparing release=notify-celery, chart=charts/notify-celery
Comparing release=k8s-event-logger, chart=/tmp/helmfile3528891494/amazon-cloudwatch/staging/k8s-event-logger/k8s-event-logger/1.1.8/k8s-event-logger
Comparing release=karpenter-crd, chart=/tmp/helmfile3528891494/karpenter/staging/karpenter-crd/karpenter-crd/0.36.1/karpenter-crd
Comparing release=karpenter, chart=/tmp/helmfile3528891494/karpenter/staging/karpenter/karpenter/0.36.1/karpenter
Comparing release=karpenter-nodepool, chart=charts/karpenter-nodepool
Comparing release=priority-classes, chart=deliveryhero/priority-class
Comparing release=secrets-store-csi-driver, chart=secrets-store-csi-driver/secrets-store-csi-driver
Comparing release=aws-secrets-provider, chart=aws-secrets-manager/secrets-store-csi-driver-provider-aws
Comparing release=kube-state-metrics, chart=prometheus-community/kube-state-metrics
Comparing release=blazer, chart=stakater/application
Comparing release=ingress, chart=charts/nginx-ingress
Comparing release=xray-daemon, chart=okgolove/aws-xray

@ben851 ben851 merged commit 46195c7 into main Dec 17, 2024
3 checks passed
@ben851 ben851 deleted the env-vars-test-fix branch December 17, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants