Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MANIFEST] switch on annual ff #3184

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[MANIFEST] switch on annual ff #3184

merged 1 commit into from
Dec 10, 2024

Conversation

jzbahrai
Copy link
Collaborator

What happens when your PR merges?

➜  notification-manifests git:(task/annual-dd) make diff-staging
Archive:  .previous.env.zip
  inflating: .env
Archive:  .env.zip
  inflating: .env
42c42
< FF_ANNUAL_LIMIT=false
---
> FF_ANNUAL_LIMIT=true
make: *** [diff-staging] Error 1

What are you changing?

  • Releasing a new version of Notify
  • Changing kubernetes configuration

Provide some background on the changes

Give details ex. Security patching, content update, more API pods etc

If you are releasing a new version of Notify, what components are you updating

  • API
  • Admin
  • Documentation
  • Document download API

Checklist if releasing new version

Checklist if making changes to Kubernetes

  • I know how to get kubectl credentials in case it catches on fire

After merging this PR

  • I have verified that the tests / deployment actions succeeded
  • I have verified that any affected pods were restarted successfully
  • I have verified that I can still log into Notify production
  • I have verified that the smoke tests still pass on production
  • I have communicated the release in the #notify Slack channel.

@jzbahrai jzbahrai requested a review from jimleroyer as a code owner December 10, 2024 19:30
Copy link
Member

@andrewleith andrewleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

< FF_ANNUAL_LIMIT=false
---
> FF_ANNUAL_LIMIT=true

Copy link

ingress	nginx    	2       	2024-02-12 19:08:42.93215444 +0000 UTC	deployed	nginx-ingress-1.1.2	3.4.2      

xray-daemon	xray     	1       	2024-07-29 19:45:48.684608347 +0000 UTC	deployed	aws-xray-4.0.8	3.3.12     

Comparing release=k8s-event-logger, chart=/tmp/helmfile1481273456/amazon-cloudwatch/staging/k8s-event-logger/k8s-event-logger/1.1.8/k8s-event-logger
Comparing release=karpenter-crd, chart=/tmp/helmfile1481273456/karpenter/staging/karpenter-crd/karpenter-crd/0.36.1/karpenter-crd
Comparing release=karpenter, chart=/tmp/helmfile1481273456/karpenter/staging/karpenter/karpenter/0.36.1/karpenter
Comparing release=karpenter-nodepool, chart=charts/karpenter-nodepool
Comparing release=priority-classes, chart=deliveryhero/priority-class
Comparing release=secrets-store-csi-driver, chart=secrets-store-csi-driver/secrets-store-csi-driver
Comparing release=aws-secrets-provider, chart=aws-secrets-manager/secrets-store-csi-driver-provider-aws
Comparing release=kube-state-metrics, chart=prometheus-community/kube-state-metrics
Comparing release=blazer, chart=stakater/application
Comparing release=ingress, chart=charts/nginx-ingress
Comparing release=xray-daemon, chart=okgolove/aws-xray

@jzbahrai jzbahrai merged commit d60caa1 into main Dec 10, 2024
5 checks passed
@jzbahrai jzbahrai deleted the task/annual-dd branch December 10, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants