Add pinpoint pool variables to k8s

[sastels]

What happens when your PR merges?

• Prefix the title of your PR:
  • feat: - tag main as a new minor release

What are you changing?

• Releasing a new version of Notify
• Changing kubernetes configuration

Provide some background on the changes

Add AWS_PINPOINT_SC_POOL_ID and AWS_PINPOINT_SC_POOL_ID environment variables to k8s. These are referenced in the Use pinpoint for designated templates api PR.

• We initially set staging and prod to empty variables.
• After testing this we will set the staging pool variables to the pool and template that has already been set up, and we will test.
• Finally we will move the short code to the prod pool and set the prod pool env vars appropriately. This will let us say when the short code definitely will be used.
• The next step is to add the long codes to the long code pool (with variable AWS_PINPOINT_LC_POOL_ID) and use that (through pinpoint) to send if the template is not in AWS_PINPOINT_SC_TEMPLATE_IDS

So currently we have:

$ make diff-staging
> AWS_PINPOINT_SC_POOL_ID=
> AWS_PINPOINT_SC_TEMPLATE_IDS=

 $ make diff-production
> AWS_PINPOINT_SC_POOL_ID=
> AWS_PINPOINT_SC_TEMPLATE_IDS=

We should merge the api PR first. That will verify that everything still works with empty variables (as will initially be the case in prod while we test). Then we can merge the manifest PR and test sending with the pool.

If you are releasing a new version of Notify, what components are you updating

• API
• Admin
• Documentation
• Document download API

Checklist if releasing new version:

• I made sure that the changes are as expected in Notify staging
• I have checked if the docker images I am referencing exist
  • api lambda (requires Notification-Production / AdministratorAccess login)
  • api k8s
  • admin
  • documentation
  • document download API

Checklist if making changes to Kubernetes:

• I know how to get kubectl credentials in case it catches on fire

After merging this PR

• I have verified that the tests / deployment actions succeeded
• I have verified that any affected pods were restarted successfully
• I have verified that I can still log into Notify production
• I have verified that the smoke tests still pass on production
• I have communicated the release in the #notify Slack channel.

[github-actions]

github-arc-ss-staging	github-arc-controller	2       	2024-04-16 19:43:09.519875873 +0000 UTC	deployed	gha-runner-scale-set-0.8.2	0.8.2      

ingress	nginx    	2       	2024-02-12 19:08:42.93215444 +0000 UTC	deployed	nginx-ingress-1.1.2	3.4.2      

Comparing release=ingress, chart=charts/nginx-ingress
Comparing release=secrets-store-csi-driver, chart=secrets-store-csi-driver/secrets-store-csi-driver
Comparing release=aws-secrets-provider, chart=aws-secrets-manager/secrets-store-csi-driver-provider-aws
Comparing release=blazer, chart=stakater/application
Comparing release=github-arc, chart=charts/gha-runner-scale-set-controller
Comparing release=github-arc-ss-staging, chart=/tmp/helmfile346843534/github-arc-controller/staging/github-arc-ss-staging/gha-runner-scale-set/0.8.2/gha-runner-scale-set

[ben851]

Is the system smart enough to know not to do stuff if the values are blank?

[sastels]

Is the system smart enough to know not to do stuff if the values are blank?

Yes but now you have me paranoid. I'll change to make the staging variables initially blank to verify.

[ben851]

Right on lets test it with empty