Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing jump box #2508

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Removing jump box #2508

merged 3 commits into from
Apr 4, 2024

Conversation

ben851
Copy link
Collaborator

@ben851 ben851 commented Mar 28, 2024

What happens when your PR merges?

The jump box configuration will no longer be applied in Notify environments.

What are you changing?

  • Changing kubernetes configuration

Provide some background on the changes

We have removed the jump box in favour of using the notify VPN.

Checklist if making changes to Kubernetes:

  • I know how to get kubectl credentials in case it catches on fire

After merging this PR

  • Manually delete the existing jumpbox deployments
kubectl delete deployment jump-box -n notification-canada-ca
kubectl delete service jump-box -n notification-canada-ca

@ben851 ben851 requested a review from jimleroyer as a code owner March 28, 2024 14:12
@ben851 ben851 mentioned this pull request Mar 28, 2024
3 tasks
Copy link

github-actions bot commented Mar 28, 2024

ingress	nginx    	2       	2024-02-12 19:08:42.93215444 +0000 UTC	deployed	nginx-ingress-1.1.2	3.4.2      

github-arc-ss-staging	github-arc-controller	1       	2024-03-18 09:49:56.990494 -0400 -0400	deployed	gha-runner-scale-set-0.8.2	0.8.2      

Comparing release=ingress, chart=charts/nginx-ingress
Comparing release=secrets-store-csi-driver, chart=secrets-store-csi-driver/secrets-store-csi-driver
Comparing release=aws-secrets-provider, chart=aws-secrets-manager/secrets-store-csi-driver-provider-aws
Comparing release=blazer, chart=stakater/application
Comparing release=github-arc, chart=charts/gha-runner-scale-set-controller
Comparing release=github-arc-ss-staging, chart=/tmp/helmfile941958910/github-arc-controller/staging/github-arc-ss-staging/gha-runner-scale-set/0.8.2/gha-runner-scale-set

Copy link
Contributor

@P0NDER0SA P0NDER0SA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty straightforward. Approved.

@ben851 ben851 merged commit 84512da into main Apr 4, 2024
4 checks passed
@ben851 ben851 deleted the jumpbox-remove-1 branch April 4, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants