-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production and testing diff output #2373
Conversation
ingress nginx 2 2024-02-12 19:08:42.93215444 +0000 UTC deployed nginx-ingress-1.1.2 3.4.2 Comparing release=ingress, chart=charts/nginx-ingress |
|
||
- name: Inject token authentication | ||
run: | | ||
git config --global url."https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/".insteadOf "https://github.com/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting stuff going on here with the insteadOf
instruction!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a copy paste from our other GA's!
uses: mshick/add-pr-comment@v2 | ||
with: | ||
message: | | ||
Placeholder for helm diff once the output from GA works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the diff issue resolved or it's ongoing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I forgot to change prod - it's resolved!
- name: Helmfile Diff Comment | ||
uses: mshick/add-pr-comment@v2 | ||
with: | ||
message: | | ||
Placeholder for helm diff once the output from GA works. | ||
${{join(steps.helmfile_diff.outputs.*, '\n')}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that is the working diff here I assume?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You got it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking like it's worth a shot.
What happens when your PR merges?
Adds workflows for Hasura and Blazer available through VPN in prod.
Also got the helmfile diff output to go to github actions comments!
What are you changing?
Provide some background on the changes
VPN