Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production and testing diff output #2373

Merged
merged 16 commits into from
Feb 13, 2024
Merged

Production and testing diff output #2373

merged 16 commits into from
Feb 13, 2024

Conversation

ben851
Copy link
Collaborator

@ben851 ben851 commented Feb 13, 2024

What happens when your PR merges?

Adds workflows for Hasura and Blazer available through VPN in prod.

Also got the helmfile diff output to go to github actions comments!

What are you changing?

  • Releasing a new version of Notify
  • Changing kubernetes configuration

Provide some background on the changes

VPN

Copy link

github-actions bot commented Feb 13, 2024

ingress nginx 2 2024-02-12 19:08:42.93215444 +0000 UTC deployed nginx-ingress-1.1.2 3.4.2

Comparing release=ingress, chart=charts/nginx-ingress
Comparing release=secrets-store-csi-driver, chart=secrets-store-csi-driver/secrets-store-csi-driver
Comparing release=aws-secrets-provider, chart=aws-secrets-manager/secrets-store-csi-driver-provider-aws
Comparing release=blazer, chart=stakater/application

@ben851 ben851 marked this pull request as ready for review February 13, 2024 18:25
@ben851 ben851 requested a review from jimleroyer as a code owner February 13, 2024 18:25

- name: Inject token authentication
run: |
git config --global url."https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/".insteadOf "https://github.com/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting stuff going on here with the insteadOf instruction!

Copy link
Collaborator Author

@ben851 ben851 Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a copy paste from our other GA's!

uses: mshick/add-pr-comment@v2
with:
message: |
Placeholder for helm diff once the output from GA works.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the diff issue resolved or it's ongoing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I forgot to change prod - it's resolved!

- name: Helmfile Diff Comment
uses: mshick/add-pr-comment@v2
with:
message: |
Placeholder for helm diff once the output from GA works.
${{join(steps.helmfile_diff.outputs.*, '\n')}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that is the working diff here I assume?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got it!

Copy link
Member

@jimleroyer jimleroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking like it's worth a shot.

@ben851 ben851 merged commit 99bea31 into main Feb 13, 2024
3 checks passed
@ben851 ben851 deleted the ingress-prod branch February 13, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants