Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/add new vars for sre auth #2141

Merged
merged 8 commits into from
Nov 7, 2023
Merged

Conversation

andrewleith
Copy link
Member

This PR adds a new environment variable for storing the secret SRE will use to call certain API methods.

What happens when your PR merges?

  • Prefix the title of your PR:
    • fix: - tag main as a new patch release
    • feat: - tag main as a new minor release
    • BREAKING CHANGE: - tag main as a new major release
    • [MANIFEST] - tag main as a new patch release and deploy to production
    • chore: - use for changes to non-app code (ex: GitHub actions)
  • Alternatively, change the VERSION file - this will not create a new tag, but rather will release the tag in VERSION to production.

What are you changing?

  • Releasing a new version of Notify
  • Changing kubernetes configuration

Provide some background on the changes

Give details ex. Security patching, content update, more API pods etc

If you are releasing a new version of Notify, what components are you updating

  • API
  • Admin
  • Documentation
  • Document download API

Checklist if releasing new version:

Checklist if making changes to Kubernetes:

  • I know how to get kubectl credentials in case it catches on fire

After merging this PR

  • I have verified that the tests / deployment actions succeeded
  • I have verified that any affected pods were restarted successfully
  • I have verified that I can still log into Notify production
  • I have verified that the smoke tests still pass on production
  • I have communicated the release in the #notify Slack channel.

@andrewleith andrewleith requested a review from ben851 November 6, 2023 20:48
Copy link
Collaborator

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add this (with dummy data if required) to the dev env vars?

@andrewleith andrewleith merged commit 4397a7a into main Nov 7, 2023
2 checks passed
@andrewleith andrewleith deleted the task/add-new-vars-for-sre-auth branch November 7, 2023 18:13
ben851 pushed a commit that referenced this pull request Dec 18, 2023
* task: add new var for sre auth

* task(sre auth): add secret key for staging

* fix: add temporary value for prod

* chore: fix bad copy/paste

* chore: pass new env vars to the API

* fix: pass new var to the correct place

* task: add env var to dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants