Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karpenter spot instances on imdsv1, celery back on spot #2128

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

ben851
Copy link
Collaborator

@ben851 ben851 commented Nov 2, 2023

What happens when your PR merges?

Karpenter instances will now you imdsv1 instead of v2 to conform with the on demand nodes and not cause fluentbit errors.

What are you changing?

  • Changing kubernetes configuration

Provide some background on the changes

Re: incident on celery metric timeout errors

@ben851 ben851 requested a review from sastels November 2, 2023 14:59
@ben851 ben851 requested a review from jimleroyer as a code owner November 2, 2023 14:59
Copy link
Collaborator

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞

@ben851 ben851 merged commit a7167e5 into main Nov 2, 2023
2 checks passed
@ben851 ben851 deleted the prod-karpenter-imdsv1 branch November 2, 2023 15:02
@sastels sastels mentioned this pull request Nov 2, 2023
19 tasks
ben851 added a commit that referenced this pull request Dec 18, 2023
* Karpenter spot instances on imdsv1, celery back on spot

* fixing yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants