Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Setting higher memory limits in cwagent #2125

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix: Setting higher memory limits in cwagent #2125

merged 1 commit into from
Nov 2, 2023

Conversation

ben851
Copy link
Collaborator

@ben851 ben851 commented Nov 1, 2023

What happens when your PR merges?

The memory limit for cwagent in kubernetes will be set to 1gb from 200mb.

What are you changing?

  • Changing kubernetes configuration

Provide some background on the changes

We are experiencing OOM crashes on cwagent.

Checklist if making changes to Kubernetes:

  • I know how to get kubectl credentials in case it catches on fire

After merging this PR

  • I have verified that the tests / deployment actions succeeded
  • I have verified that any affected pods were restarted successfully
  • I have verified that I can still log into Notify production
  • I have verified that the smoke tests still pass on production
  • I have communicated the release in the #notify Slack channel.

@ben851 ben851 requested a review from sastels November 1, 2023 20:26
@ben851 ben851 requested a review from jimleroyer as a code owner November 1, 2023 20:26
sastels
sastels approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 assuming we have the memory available?

@ben851 ben851 merged commit 513ac89 into main Nov 2, 2023
2 checks passed
@ben851 ben851 deleted the cwagent-memory-upgrade branch November 2, 2023 12:35
@sastels sastels mentioned this pull request Nov 2, 2023
Merged
19 tasks
ben851 added a commit that referenced this pull request Dec 18, 2023
@ben851
Setting higher memory limits in cwagent (#2125)
7ab5d89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sastels sastels sastels approved these changes

@jimleroyer jimleroyer Awaiting requested review from jimleroyer jimleroyer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben851 @sastels