Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enabling consolodation #2121

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Re-enabling consolodation #2121

merged 3 commits into from
Nov 7, 2023

Conversation

ben851
Copy link
Collaborator

@ben851 ben851 commented Oct 31, 2023

What happens when your PR merges?

Staging will have node consolidation re-enabled to save on the $$

Provide some background on the changes

Part of node autoscaling work

@ben851 ben851 requested a review from sastels October 31, 2023 19:41
@ben851 ben851 requested a review from jimleroyer as a code owner October 31, 2023 19:41
sastels
sastels approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ben851 ben851 merged commit ed715f0 into main Nov 7, 2023
2 checks passed
@ben851 ben851 deleted the karpenter-consolidation-staging branch November 7, 2023 14:24
ben851 added a commit that referenced this pull request Dec 18, 2023
@ben851
Re-enabling consolodation (#2121)
9747879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sastels sastels sastels approved these changes

@jimleroyer jimleroyer Awaiting requested review from jimleroyer jimleroyer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben851 @sastels