Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating workflow for Docker Tags #2408

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Updating workflow for Docker Tags #2408

merged 4 commits into from
Jan 9, 2025

Conversation

P0NDER0SA
Copy link
Contributor

Summary | Résumé

Adding a workflow that runs on merge to main, calls a workflow in manifests to update the docker image tag in our manifests configuration files.

Test instructions | Instructions pour tester la modification

watch that this runs on merge to main, and then check to see if the file has been updated in manifests here:
https://github.com/cds-snc/notification-manifests/blob/main/helmfile/overrides/staging.env

Related Issues | Cartes liées

https://app.zenhub.com/workspaces/notify-planning-core-6411dfb7c95fb80014e0cab0/issues/gh/cds-snc/notification-planning-core/491

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

Copy link
Contributor

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P0NDER0SA P0NDER0SA enabled auto-merge (squash) January 9, 2025 16:26
@P0NDER0SA P0NDER0SA merged commit 94c440c into main Jan 9, 2025
5 checks passed
@P0NDER0SA P0NDER0SA deleted the helm-tagging2 branch January 9, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants