Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving error reporting on document download #2395

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

ben851
Copy link
Contributor

@ben851 ben851 commented Dec 16, 2024

Summary | Résumé

I spent a good couple hrs last week trying to figure out why document download was up but was returning 503's (service unavailable) when being called by api. Removing hard-coded 503 to return the actual http status code and also improving messaging.

Related Issues | Cartes liées

Chore

Test instructions | Instructions pour tester la modification

Break document download and view the errors.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

Copy link
Collaborator

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ben851 ben851 merged commit 42a6e81 into main Dec 16, 2024
5 checks passed
@ben851 ben851 deleted the doc-download-errors branch December 16, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants