Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 second try #2392

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from
Draft

Python 3.12 second try #2392

wants to merge 38 commits into from

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Dec 12, 2024

Summary | Résumé

Change api to Python 3.12 !

Note the switch to debian-slim as a base container. Using alpine was causing failures connecting the New Relic layer to the lambda function :/

We need to merge the utils branch before we can merge main into this PR

  • note that utils has "delete head branch" disabled now, so we can merge without deleting the branch currently used by staging / prod

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

TODO: Fill in test instructions for the reviewer.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant