Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official 3.10 New Relic later and Debian slim #2387

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Dec 10, 2024

Summary | Résumé

Having issues with the official New Relic layers after 3.9 and alpine. Builds fine but cannot register with AWS Lambda.

Here we

  • switch to the recommended Debian distribution (well, Debian-slim).
  • download the official New Relic layer for 3.10 rather than using the one we made ourselves. (the download script has been changed to reflect this)

Surprisingly this debian based image is 20% smaller than the current alpine based image.

We will test this in staging and if all is good we will revert it and see if the 3.12 upgrade works with Debian.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

This has been built and deployed to dev and can be tested there.

  • go to the dev lambda function
  • under the "test" tab choose the template "API Gateway Http API"
  • click the "test" button.
  • the "executing function" box should eventually turn green. The details say a 404 was returned.
  • To get the status out of api, change the "rawPath" on line 4 to "/" and the "method" on line 48 to "GET". Testing this should result in a 200 and the api status line.
  • run the test a bunch (10-20 times).
  • after a few minutes your invocations should show up in the New Relic dashboard

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@sastels sastels marked this pull request as ready for review December 10, 2024 20:03
Copy link
Contributor

@P0NDER0SA P0NDER0SA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, worth a try for sure!

Copy link
Contributor

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debian all the things!

@sastels sastels merged commit 5a1826e into main Dec 13, 2024
5 checks passed
@sastels sastels deleted the 3.10-debian-slim branch December 13, 2024 15:22
sastels added a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants