Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit emails #2373

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Limit emails #2373

merged 2 commits into from
Dec 4, 2024

Conversation

jzbahrai
Copy link
Collaborator

@jzbahrai jzbahrai commented Nov 28, 2024

Summary | Résumé

Add the annual email limit sending in this PR

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

TODO: Fill in test instructions for the reviewer.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@jzbahrai jzbahrai marked this pull request as ready for review December 2, 2024 22:00
@jzbahrai jzbahrai force-pushed the limit-emails branch 3 times, most recently from 10cec63 to 0a93bf3 Compare December 2, 2024 22:29
Base automatically changed from task/enforce-annual-limits to main December 3, 2024 20:33
app/notifications/validators.py Fixed Show resolved Hide resolved
Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jzbahrai jzbahrai merged commit b34aebb into main Dec 4, 2024
6 checks passed
@jzbahrai jzbahrai deleted the limit-emails branch December 4, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants