fix: add fallback value for cypress migration #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| (current_app.config["CYPRESS_USER_PW_SECRET"] + current_app.config["DANGEROUS_SALT"]).encode("utf-8") | ||
| ).hexdigest() | ||
| ) | ||
| password = hashpw(hashlib.sha256((cypress_user_pw + current_app.config["DANGEROUS_SALT"]).encode("utf-8")).hexdigest()) |
There was a problem hiding this comment.
The hashpw function call is missing a closing parenthesis. It should be hashpw(hashlib.sha256((cypress_user_pw + current_app.config["DANGEROUS_SALT"]).encode("utf-8")).hexdigest()).
There was a problem hiding this comment.
Funny, the suggestion is exactly what is in the code.
jimleroyer
reviewed
Nov 14, 2024
| @@ -28,14 +28,13 @@ | |||
| email_template_id = current_app.config["CYPRESS_SMOKE_TEST_EMAIL_TEMPLATE_ID"] | |||
| sms_template_id = current_app.config["CYPRESS_SMOKE_TEST_SMS_TEMPLATE_ID"] | |||
| default_category_id = current_app.config["DEFAULT_TEMPLATE_CATEGORY_LOW"] | |||
| cypress_user_pw = current_app.config.get( | |||
| "CYPRESS_USER_PW_SECRET", uuid.uuid4().hex[:32] # if env var isn't present, use a random password | |||
| ) | |||
There was a problem hiding this comment.
Looks good! I wonder if a log should be printed to the console to warn about the fall back if it occurs. It's good as is though for me.
There was a problem hiding this comment.
Yeah thats a good idea, I'll add that in.
There was a problem hiding this comment.
Does that look good? Does logging work the same way in a migration as it does in the app?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR adds a fallback for the cypress secret so that migrations will continue to work even if it isn't in the
.envfile.Test instructions | Instructions pour tester la modification
TODO: Fill in test instructions for the reviewer.
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur