use empty string for empty pool id

[sastels]

Summary | Résumé

We have

os.getenv("AWS_PINPOINT_DEFAULT_POOL_ID", None)

However if in our env var file we have

AWS_PINPOINT_DEFAULT_POOL_ID=

Then the pool id will be set to the empty string which will cause an error later on. Here we use the empty string instead of None as a default value.

Related Issues | Cartes liées

• https://app.zenhub.com/workspaces/notify-planning-core-6411dfb7c95fb80014e0cab0/issues/gh/cds-snc/notification-planning-core/360

Test instructions | Instructions pour tester la modification

Set

AWS_PINPOINT_SC_POOL_ID = "pool-b20333ce1e4e49309ba1db3bf94a3f57"
AWS_PINPOINT_SC_TEMPLATE_IDS = <one of your templates>
AWS_PINPOINT_DEFAULT_POOL_ID=

Send an sms with the template listed and one with a different template. All SMS should be delivered with no errors. the one from the sc template should be sent with Pinpoint.

Now set

AWS_PINPOINT_SC_POOL_ID=

and send with the sc template. The sms should send with no errors from SNS.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

• This PR does not break existing functionality.
• This PR does not violate GCNotify's privacy policies.
• This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
• This PR does not significantly alter performance.
• Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

[ben851]

LGTM