Task/remove letters #2185
Merged
Task/remove letters #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewleith
reviewed
Jun 4, 2024
Comment on lines
9
to
+11
| @letter_job.route("/letters/returned", methods=["POST"]) | ||
| def create_process_returned_letters_job(): | ||
| references = validate(request.get_json(), letter_references) | ||
|
|
||
| return jsonify(references=references["references"]), 200 | ||
| pass |
There was a problem hiding this comment.
Why not get rid of all of this, would that cause other issues?
There was a problem hiding this comment.
I was just leaving this until we remove the routes from ADMIN.
app/letters/utils.py
Outdated
There was a problem hiding this comment.
Can we not delete this entire file?
There was a problem hiding this comment.
we could! Lets do this incrementally though. I removed a bunch, will keep removing more cause its a lot of finding is something is called elsewhere or not.
| @@ -793,8 +773,7 @@ def create_one_off_notification(service_id): | |||
|
|
|||
| @service_blueprint.route("/<uuid:service_id>/send-pdf-letter", methods=["POST"]) | |||
| def create_pdf_letter(service_id): | |||
| resp = send_pdf_letter_notification(service_id, request.get_json()) | |||
| return jsonify(resp), 201 | |||
| pass | |||
There was a problem hiding this comment.
Are these routes reachable by end-users? If so, what kind of response is received after this change?
There was a problem hiding this comment.
I think they are currently in admin, though not visible. will remove them all in another pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Remove letter code