Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore SUCCESSFUL pinpoint receipts #2176

Merged
merged 2 commits into from
May 13, 2024

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented May 9, 2024

Summary | Résumé

Pinpoint returns a SUCCESSFUL receipt when it sends the text to the carrier. Right now we'll just ignore these (the notification is already set to "sent") and wait for a DELIVERED or some sort of failure.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

send in staging and make sure the process-pinpoint-result task doesn't complain

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@sastels sastels force-pushed the deal-with-successful-pinpoint-receipts branch from 8a68e19 to 260e787 Compare May 9, 2024 19:33
@sastels sastels changed the title Deal with SUCCESSFUL pinpoint receipts Ignore with SUCCESSFUL pinpoint receipts May 9, 2024
@sastels sastels changed the title Ignore with SUCCESSFUL pinpoint receipts Ignore SUCCESSFUL pinpoint receipts May 9, 2024
Copy link
Contributor

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sastels sastels marked this pull request as ready for review May 13, 2024 11:18
@sastels sastels merged commit 86fb27b into main May 13, 2024
4 checks passed
@sastels sastels deleted the deal-with-successful-pinpoint-receipts branch May 13, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants