Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for freshdesk ticket for name and logos #2174

Merged
merged 7 commits into from
May 9, 2024
Merged

Conversation

jzbahrai
Copy link
Collaborator

@jzbahrai jzbahrai commented May 8, 2024

Summary | Résumé

We need to send alt_text_en, alt_text_fr and branding_logo_name to the freshdesk ticket

Test instructions | Instructions pour tester la modification

hard to test as we dont have freshdesk locally

Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! - I remember reviewing code for this at one point. Curious that it didn't make it into the original release. I was remembering the extra org info we included per Jimmy P's request.

@jzbahrai jzbahrai enabled auto-merge (squash) May 9, 2024 15:51
@jzbahrai jzbahrai merged commit 6770073 into main May 9, 2024
4 checks passed
@jzbahrai jzbahrai deleted the task/fix-freshdesk branch May 9, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants