Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add template for magic link auth #2171

Merged
merged 1 commit into from
May 8, 2024
Merged

Add template for magic link auth #2171

merged 1 commit into from
May 8, 2024

Conversation

jzbahrai
Copy link
Collaborator

@jzbahrai jzbahrai commented May 6, 2024 •
edited
Loading

Summary | Résumé

Add another way to do 2 factor auth by adding a magic link. This creates the template

Related Issues | Cartes liées

https://app.zenhub.com/workspaces/notify-planning-614b3ad91bc2030015ed22f5/issues/gh/cds-snc/notification-planning/603

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 6, 2024
View reviewed changes
migrations/versions/0449_update_magic_link_auth.py


def upgrade():
conn = op.get_bind()

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable conn is not used.
@jzbahrai jzbahrai requested review from whabanks and andrewleith May 8, 2024 13:21
jzbahrai
jzbahrai commented May 8, 2024
View reviewed changes
migrations/versions/0449_update_magic_link_auth.py
)
)

op.execute("INSERT INTO auth_type (name) VALUES ('magic_link')")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a new auth type - "magic link"

whabanks
whabanks approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested locally with flask db upgrade.

andrewleith
andrewleith approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@andrewleith andrewleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - new auth type and template are created properly locally.

@jzbahrai jzbahrai merged commit 9471eed into main May 8, 2024
4 checks passed
@jzbahrai jzbahrai deleted the task/add-magic-link-template branch May 8, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whabanks whabanks whabanks approved these changes

@andrewleith andrewleith andrewleith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzbahrai @andrewleith @whabanks