Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pinpoint for designated templates #2152
Use pinpoint for designated templates #2152
Changes from 1 commit
9740520
064e36d
b9d0d3a
0fa34c1
7e69706
b3d12e5
fe263c6
d18ce27
fceab9f
b8ceb91
1a6ba9e
6e3d339
ca2da8c
7ec198b
3db48e8
d2e8471
c8eb6c5
6c090ce
3f59f27
646b86d
bde0f68
12f539f
965fbff
26d4419
5710df2
28524bb
efa0df9
d1612c2
c08cc14
aed401f
e205bc1
41e7eaa
40e4c87
f09cec5
fde4812
040a361
da4006f
188d0b6
b4e2bd8
afec912
337c594
7fb51e1
7723702
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
US
parameter is to say the phone number has an American phone number format?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used as the default region, ie if you don't start your number with a region code then we assume it's US / CA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can combine these two if the logic is exactly the same.
There might be syntactic sugar to avoid the tuple and rather use the
|
operator nowadays, not sure..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 a
ClientError
is anException
so I think we can just get rid of theClientError
bit alltogether!Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note