-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8s rollout workflow #2134
Merged
Merged
K8s rollout workflow #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-api into k8s-rollout-workflow
sastels
reviewed
Mar 7, 2024
sastels
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
…n-api into k8s-rollout-workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This will move the Kubernetes rollout in the docker build GitHub Action to the new workflow in notifications-manifest.
This is required in order to support having a private EKS cluster.
Related Issues | Cartes liées
Test instructions | Instructions pour tester la modification
This can't be tested until it's merged due to issues with the AWS Auth.
I have removed the docker build/push steps and ensured that the call from this workflow to the manifests workflow works.
I will be standing by to revert this in the event it doesn't work.
Release Instructions | Instructions pour le déploiement
Release, and ensure that the kubernetes rollout job in notification-manifests is run.
Reviewer checklist | Liste de vérification du réviseur