Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s rollout workflow #2134

Merged
merged 27 commits into from
Mar 7, 2024
Merged

K8s rollout workflow #2134

merged 27 commits into from
Mar 7, 2024

Conversation

ben851
Copy link
Contributor

@ben851 ben851 commented Mar 7, 2024

Summary | Résumé

This will move the Kubernetes rollout in the docker build GitHub Action to the new workflow in notifications-manifest.

This is required in order to support having a private EKS cluster.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

This can't be tested until it's merged due to issues with the AWS Auth.

I have removed the docker build/push steps and ensured that the call from this workflow to the manifests workflow works.

I will be standing by to revert this in the event it doesn't work.

Release Instructions | Instructions pour le déploiement

Release, and ensure that the kubernetes rollout job in notification-manifests is run.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@ben851 ben851 marked this pull request as ready for review March 7, 2024 19:12
Copy link
Collaborator

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@ben851 ben851 merged commit da146e2 into main Mar 7, 2024
4 checks passed
@ben851 ben851 deleted the k8s-rollout-workflow branch March 7, 2024 19:54
ben851 added a commit that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants