Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add diagnostic logging to create_job #2130

Merged
merged 4 commits into from
Mar 5, 2024
Merged

add diagnostic logging to create_job #2130

merged 4 commits into from
Mar 5, 2024

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Mar 5, 2024

Summary | Résumé

The api lambda is sometimes taking so long to run that the api gateway times out. This PR adds some logging to the culprit function to try to see where the time is being spent.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

This has to be run in staging. After the logging is added, we'll upload a 50K file to the test template as described in the card.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

Copy link
Member

@jimleroyer jimleroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what that gives.

@sastels sastels merged commit 6f4903d into main Mar 5, 2024
4 checks passed
@sastels sastels deleted the add-diagnostic-logging branch March 5, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants