Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency nodemailer to v6.9.9 [security] #2100

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 1, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
nodemailer (source) 6.9.8 -> 6.9.9 age adoption passing confidence

Review

  • Updates have been tested and work
  • If updates are AWS related, versions match the infrastructure (e.g. Lambda runtime, database, etc.)

GitHub Vulnerability Alerts

GHSA-9h6g-pr28-7cqp

Summary

A ReDoS vulnerability occurs when nodemailer tries to parse img files with the parameter attachDataUrls set, causing the stuck of event loop.
Another flaw was found when nodemailer tries to parse an attachments with a embedded file, causing the stuck of event loop.

Details

Regex: /^data:((?:[^;];)(?:[^,])),(.)$/

Path: compile -> getAttachments -> _processDataUrl

Regex: /(<img\b[^>]* src\s*=[\s"']*)(data:([^;]+);[^"'>\s]+)/

Path: _convertDataImages

PoC

https://gist.github.com/francoatmega/890dd5053375333e40c6fdbcc8c58df6
https://gist.github.com/francoatmega/9aab042b0b24968d7b7039818e8b2698

Impact

ReDoS causes the event loop to stuck a specially crafted evil email can cause this problem.


Release Notes

nodemailer/nodemailer (nodemailer)

v6.9.9

Compare Source

Bug Fixes
  • security: Fix issues described in GHSA-9h6g-pr28-7cqp. Do not use eternal matching pattern if only a few occurences are expected (dd8f5e8)
  • tests: Use native node test runner, added code coverage support, removed grunt (#​1604) (be45c1b)

Configuration

📅 Schedule: Branch creation - "" in timezone America/Montreal, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update a dependency file Renovate labels Feb 1, 2024
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 7 times, most recently from 0a53561 to 5a9b7b2 Compare February 6, 2024 20:43
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 8 times, most recently from 184f986 to 5717aff Compare February 26, 2024 15:56
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 4 times, most recently from bec7d79 to 5213b38 Compare March 5, 2024 21:45
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 8 times, most recently from 8d9edad to cba9c9c Compare March 12, 2024 20:29
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch from cba9c9c to 7d2ec38 Compare March 15, 2024 14:56
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 7 times, most recently from bbfe81b to 1cc79ad Compare March 25, 2024 15:43
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 2 times, most recently from ae7ba5e to 1c35395 Compare March 26, 2024 19:32
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch from 1c35395 to 4961efe Compare April 2, 2024 18:49
@whabanks whabanks merged commit d27a0db into main Apr 9, 2024
5 checks passed
@whabanks whabanks deleted the renovate/npm-nodemailer-vulnerability branch April 9, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Renovate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant